[
https://issues.apache.org/jira/browse/ARROW-2281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16407873#comment-16407873
]
ASF GitHub Bot commented on ARROW-2281:
---------------------------------------
pitrou commented on a change in pull request #1772: ARROW-2281: [Python] Add
Array.from_buffers()
URL: https://github.com/apache/arrow/pull/1772#discussion_r176073851
##########
File path: cpp/src/arrow/array.h
##########
@@ -111,6 +111,11 @@ struct ARROW_EXPORT ArrayData {
int64_t null_count =
kUnknownNullCount,
int64_t offset = 0);
+ static std::shared_ptr<ArrayData> Make(
Review comment:
This addition avoids having to spell the `std::move` declaration in Cython...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [Python] Expose MakeArray to construct arrays from buffers
> ----------------------------------------------------------
>
> Key: ARROW-2281
> URL: https://issues.apache.org/jira/browse/ARROW-2281
> Project: Apache Arrow
> Issue Type: Improvement
> Components: Python
> Reporter: Uwe L. Korn
> Assignee: Antoine Pitrou
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.10.0
>
>
> To create new arrays from existing buffers in Python, we would need to call
> into the C++ {{MakeArray}} method. This would then construct the Array and we
> would only wrap it in Python to have construction support for all Array types.
> This would also mean that we need to have a Python representation of
> {{ArrayData}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
