cpcloud commented on a change in pull request #23: Build wheels for 0.9.0
URL: https://github.com/apache/arrow-dist/pull/23#discussion_r176430659
 
 

 ##########
 File path: cpp-linux/yum/arrow.spec.in
 ##########
 @@ -60,13 +60,17 @@ mkdir cpp/build
 cd cpp/build
 %cmake3 .. \
   -DCMAKE_BUILD_TYPE=$build_type \
+  -DARROW_ORC=ON \
 %if %{use_python}
-  -DARROW_PYTHON=yes \
+  -DARROW_PYTHON=ON \
+  -DPythonInterp_FIND_VERSION=ON \
+  -DPythonInterp_FIND_VERSION_MAJOR=3 \
 %endif
 %if %{_centos_ver} == 6
-  -DARROW_BOOST_VENDORED=yes \
+  -DARROW_BOOST_VENDORED=ON \
 %endif
 
 Review comment:
   Do we need an `%else` here to say `-DARROW_BOOST_USE_SHARED=ON`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to