[
https://issues.apache.org/jira/browse/ARROW-2333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16409951#comment-16409951
]
ASF GitHub Bot commented on ARROW-2333:
---------------------------------------
xhochy closed pull request #1773: ARROW-2333: [Python] Fix bundling boost with
default namespace
URL: https://github.com/apache/arrow/pull/1773
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/python/setup.py b/python/setup.py
index 453626020..cf44b1e43 100644
--- a/python/setup.py
+++ b/python/setup.py
@@ -111,7 +111,7 @@ def initialize_options(self):
_build_ext.initialize_options(self)
self.extra_cmake_args = os.environ.get('PYARROW_CMAKE_OPTIONS', '')
self.build_type = os.environ.get('PYARROW_BUILD_TYPE', 'debug').lower()
- self.boost_namespace = os.environ.get('PYARROW_BOOST_NAMESPACE')
+ self.boost_namespace = os.environ.get('PYARROW_BOOST_NAMESPACE',
'boost')
self.cmake_cxxflags = os.environ.get('PYARROW_CXXFLAGS', '')
@@ -208,7 +208,7 @@ def _run_cmake(self):
cmake_options.append('-DCMAKE_BUILD_TYPE={0}'
.format(self.build_type.lower()))
- if self.boost_namespace is not None:
+ if self.boost_namespace != 'boost':
cmake_options.append('-DBoost_NAMESPACE={}'
.format(self.boost_namespace))
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [Python] boost bundling fails in setup.py
> -----------------------------------------
>
> Key: ARROW-2333
> URL: https://issues.apache.org/jira/browse/ARROW-2333
> Project: Apache Arrow
> Issue Type: Bug
> Components: Python
> Affects Versions: 0.9.0
> Reporter: Antoine Pitrou
> Assignee: Antoine Pitrou
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.10.0
>
>
> {code}
> [...]
> File "setup.py", line 88, in run
> self._run_cmake()
> File "setup.py", line 280, in _run_cmake
> "{}_filesystem".format(self.boost_namespace))
> File "setup.py", line 386, in move_shared_libs
> _move_shared_libs_unix(build_prefix, build_lib, lib_name)
> File "setup.py", line 408, in _move_shared_libs_unix
> ' in ' + build_prefix)
> Exception: Could not find library:libNone_filesystem.so in
> release
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
