[
https://issues.apache.org/jira/browse/ARROW-2349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16412417#comment-16412417
]
ASF GitHub Bot commented on ARROW-2349:
---------------------------------------
wesm closed pull request #1786: ARROW-2349: [Python] Opt in to bundling Boost
shared libraries separately
URL: https://github.com/apache/arrow/pull/1786
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/python/CMakeLists.txt b/python/CMakeLists.txt
index 44a3c6c91..cb3cd7023 100644
--- a/python/CMakeLists.txt
+++ b/python/CMakeLists.txt
@@ -78,7 +78,7 @@ if("${CMAKE_SOURCE_DIR}" STREQUAL
"${CMAKE_CURRENT_SOURCE_DIR}")
OFF)
option(PYARROW_BUNDLE_BOOST
"Bundle the Boost libraries when we bundle Arrow C++"
- ON)
+ OFF)
set(PYARROW_CXXFLAGS "" CACHE STRING
"Compiler flags to append when compiling Arrow")
endif()
diff --git a/python/setup.py b/python/setup.py
index 472469053..91e0bb93d 100644
--- a/python/setup.py
+++ b/python/setup.py
@@ -136,7 +136,7 @@ def initialize_options(self):
# Default is True but this only is actually bundled when
# we also bundle arrow-cpp.
self.bundle_boost = strtobool(
- os.environ.get('PYARROW_BUNDLE_BOOST', '1'))
+ os.environ.get('PYARROW_BUNDLE_BOOST', '0'))
CYTHON_MODULE_NAMES = [
'lib',
@@ -195,15 +195,15 @@ def _run_cmake(self):
if self.bundle_arrow_cpp:
cmake_options.append('-DPYARROW_BUNDLE_ARROW_CPP=ON')
- cmake_options.append('-DPYARROW_BUNDLE_BOOST=ON')
# ARROW-1090: work around CMake rough edges
if 'ARROW_HOME' in os.environ and sys.platform != 'win32':
pkg_config = pjoin(os.environ['ARROW_HOME'], 'lib',
'pkgconfig')
os.environ['PKG_CONFIG_PATH'] = pkg_config
del os.environ['ARROW_HOME']
- else:
- cmake_options.append('-DPYARROW_BUNDLE_BOOST=OFF')
+
+ if self.bundle_boost:
+ cmake_options.append('-DPYARROW_BUNDLE_BOOST=ON')
cmake_options.append('-DCMAKE_BUILD_TYPE={0}'
.format(self.build_type.lower()))
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [Python] Boost shared library bundling is broken for MSVC
> ---------------------------------------------------------
>
> Key: ARROW-2349
> URL: https://issues.apache.org/jira/browse/ARROW-2349
> Project: Apache Arrow
> Issue Type: Bug
> Components: Python
> Reporter: Wes McKinney
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.10.0
>
>
> See
> https://ci.appveyor.com/project/ApacheSoftwareFoundation/arrow-dist/build/1.0.127/job/fjxeaecwidgb6mqr
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
