[
https://issues.apache.org/jira/browse/ARROW-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16417497#comment-16417497
]
ASF GitHub Bot commented on ARROW-2351:
---------------------------------------
xhochy commented on issue #1803: ARROW-2351 [C++]
StringBuilder::append(vector<string>...) not impleme…
URL: https://github.com/apache/arrow/pull/1803#issuecomment-376921022
> hmmm, is it possible that the string is not empty and the null bit is true
?
No, this should not happen but this should hopefully not make a difference.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [C++] StringBuilder::append(vector<string>...) not implemented
> --------------------------------------------------------------
>
> Key: ARROW-2351
> URL: https://issues.apache.org/jira/browse/ARROW-2351
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++
> Affects Versions: 0.9.0
> Reporter: Rares Vernica
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.10.0
>
>
> For {{StringBuilder}} an {{append(vector<string>, uint8_t*)}} function is
> [declared|https://github.com/apache/arrow/blob/7b2c79765cf92760e1f8cca079159d9613b86412/cpp/src/arrow/builder.h#L721]
> and
> [documented|http://arrow.apache.org/docs/cpp/classarrow_1_1_string_builder.html#a59be34b5e11017a392b4ee019d90da3c]
> but it does not seem to be implemented.
> {code:java}
> undefined reference to `arrow::StringBuilder::Append(std::vector<std::string,
> std::allocator<std::string> > const&, unsigned char*)'
> collect2: error: ld returned 1 exit status
> {code}
> Also worth noting is that the similar function in {{NumericBuilder}} uses
> {{vector<bool>}} for the null values instead of {{uint8_t*}}. It might be
> worth making them consistent.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
