cpcloud commented on a change in pull request #25: Fix OSX RPATHs for Boost
URL: https://github.com/apache/arrow-dist/pull/25#discussion_r178132846
##########
File path: python-macos/config.sh
##########
@@ -153,9 +187,19 @@ function build_wheel {
--bundle-arrow-cpp --bundle-boost --boost-namespace=arrow_boost \
bdist_wheel
ls -l dist/
+
+ # Do a test installation of the built wheel and change into another
+ # directory to ensure our import tests later on pick up the wheel and
+ # not the binaries from the build directory.
for wheel in dist/*.whl; do
- unzip -l "$wheel"
+ pip install "$wheel"
+ unzip -l "$wheel"
Review comment:
I don't think we need `unzip` anymore, this was for debugging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
