[
https://issues.apache.org/jira/browse/ARROW-2377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16423458#comment-16423458
]
ASF GitHub Bot commented on ARROW-2377:
---------------------------------------
xhochy closed pull request #1826: ARROW-2377: [GLib] Support old GObject
Introspection
URL: https://github.com/apache/arrow/pull/1826
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/c_glib/test/test-list-array.rb b/c_glib/test/test-list-array.rb
index 7f2c96787..14f84067a 100644
--- a/c_glib/test/test-list-array.rb
+++ b/c_glib/test/test-list-array.rb
@@ -21,7 +21,8 @@ class TestListArray < Test::Unit::TestCase
def test_new
value_offsets = Arrow::Buffer.new([0, 2, 5, 5].pack("l*"))
data = Arrow::Buffer.new([1, 2, 3, 4, 5].pack("c*"))
- values = Arrow::Int8Array.new(5, data, nil, 0)
+ nulls = Arrow::Buffer.new([0b11111].pack("C*"))
+ values = Arrow::Int8Array.new(5, data, nulls, 0)
assert_equal(build_list_array(Arrow::Int8DataType.new,
[[1, 2], [3, 4, 5], nil]),
Arrow::ListArray.new(3,
diff --git a/c_glib/test/test-struct-array.rb b/c_glib/test/test-struct-array.rb
index 29219f863..c55e95e4f 100644
--- a/c_glib/test/test-struct-array.rb
+++ b/c_glib/test/test-struct-array.rb
@@ -37,9 +37,10 @@ def test_new
struct_array1 = build_struct_array(fields, structs)
data_type = Arrow::StructDataType.new(fields)
+ nulls = Arrow::Buffer.new([0b11].pack("C*"))
children = [
- Arrow::Int8Array.new(2, Arrow::Buffer.new([-29, 2].pack("C*")), nil, 0),
- Arrow::BooleanArray.new(2, Arrow::Buffer.new([0b01].pack("C*")), nil, 0),
+ Arrow::Int8Array.new(2, Arrow::Buffer.new([-29, 2].pack("C*")), nulls,
0),
+ Arrow::BooleanArray.new(2, Arrow::Buffer.new([0b01].pack("C*")), nulls,
0),
]
assert_equal(struct_array1,
Arrow::StructArray.new(data_type,
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [GLib] Travis-CI failures
> -------------------------
>
> Key: ARROW-2377
> URL: https://issues.apache.org/jira/browse/ARROW-2377
> Project: Apache Arrow
> Issue Type: Bug
> Components: Continuous Integration, GLib
> Reporter: Antoine Pitrou
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.10.0
>
>
> See this (empty) PR:
> https://github.com/apache/arrow/pull/1822
> It results in failures on the GLib builds:
> https://travis-ci.org/apache/arrow/builds/361145322
> {code}================================================================================
> /home/travis/build/apache/arrow/c_glib/test/test-list-array.rb:24:in
> `test_new'
> 21: def test_new
> 22: value_offsets = Arrow::Buffer.new([0, 2, 5, 5].pack("l*"))
> 23: data = Arrow::Buffer.new([1, 2, 3, 4, 5].pack("c*"))
> => 24: values = Arrow::Int8Array.new(5, data, nil, 0)
> 25: assert_equal(build_list_array(Arrow::Int8DataType.new,
> 26: [[1, 2], [3, 4, 5], nil]),
> 27: Arrow::ListArray.new(3,
> /home/travis/build/apache/arrow/c_glib/test/test-list-array.rb:24:in `new'
> /home/travis/.rvm/gems/ruby-2.4.1/gems/gobject-introspection-3.2.2/lib/gobject-introspection/loader.rb:328:in
> `block in load_constructor_infos'
> /home/travis/.rvm/gems/ruby-2.4.1/gems/gobject-introspection-3.2.2/lib/gobject-introspection/loader.rb:317:in
> `block (2 levels) in load_constructor_infos'
> /home/travis/.rvm/gems/ruby-2.4.1/gems/gobject-introspection-3.2.2/lib/gobject-introspection/loader.rb:317:in
> `invoke'
> Error: test_new(TestListArray): ArgumentError: <Arrow::Int8Array#new>: the
> 2nd argument must not nil: <null_bitmap>
> ================================================================================
> ...........................................E
> ================================================================================
> /home/travis/build/apache/arrow/c_glib/test/test-struct-array.rb:41:in
> `test_new'
> 38:
> 39: data_type = Arrow::StructDataType.new(fields)
> 40: children = [
> => 41: Arrow::Int8Array.new(2, Arrow::Buffer.new([-29,
> 2].pack("C*")), nil, 0),
> 42: Arrow::BooleanArray.new(2,
> Arrow::Buffer.new([0b01].pack("C*")), nil, 0),
> 43: ]
> 44: assert_equal(struct_array1,
> /home/travis/build/apache/arrow/c_glib/test/test-struct-array.rb:41:in `new'
> /home/travis/.rvm/gems/ruby-2.4.1/gems/gobject-introspection-3.2.2/lib/gobject-introspection/loader.rb:328:in
> `block in load_constructor_infos'
> /home/travis/.rvm/gems/ruby-2.4.1/gems/gobject-introspection-3.2.2/lib/gobject-introspection/loader.rb:317:in
> `block (2 levels) in load_constructor_infos'
> /home/travis/.rvm/gems/ruby-2.4.1/gems/gobject-introspection-3.2.2/lib/gobject-introspection/loader.rb:317:in
> `invoke'
> Error: test_new(TestStructArray): ArgumentError: <Arrow::Int8Array#new>: the
> 2nd argument must not nil: <null_bitmap>
> ================================================================================
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
