[ 
https://issues.apache.org/jira/browse/ARROW-2380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16425712#comment-16425712
 ] 

ASF GitHub Bot commented on ARROW-2380:
---------------------------------------

pitrou opened a new pull request #1835: [WIP] ARROW-2380: [Python] Streamline 
conversions
URL: https://github.com/apache/arrow/pull/1835
 
 
   * Correctly check for overflow when constructing string / binary objects
   * Accept bytearrays in the same places as bytes objects
   * Other small refactorings

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [Python] Correct issues in numpy_to_arrow conversion routines
> -------------------------------------------------------------
>
>                 Key: ARROW-2380
>                 URL: https://issues.apache.org/jira/browse/ARROW-2380
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: Python
>    Affects Versions: 0.9.0
>            Reporter: Bryan Cutler
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 0.10.0
>
>
> Following the discussion at [https://github.com/apache/arrow/pull/1689,] 
> there are a few issues with conversion of various types to arrow that are 
> incorrect or could be improved:
>  * PyBytes_GET_SIZE is being casted to the wrong type, for example 
> {{const int32_t length = static_cast<int32_t>(PyBytes_GET_SIZE(obj));}}
>  * Handle the possibility with the statement
> {{builder->value_data_length() + length > kBinaryMemoryLimit}}
> if length is larger than kBinaryMemoryLimit
>  * Look into using common code for binary object conversion to avoid 
> duplication, and allow support for bytes and bytearray objects in other 
> places than numpy_to_arrow.  (possibly put in src/arrow/python/helpers.h)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to