[
https://issues.apache.org/jira/browse/ARROW-2385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16426014#comment-16426014
]
ASF GitHub Bot commented on ARROW-2385:
---------------------------------------
maxim-lian commented on a change in pull request #1829: ARROW-2385: [Rust]
implement to_json for DataType and Field
URL: https://github.com/apache/arrow/pull/1829#discussion_r179248743
##########
File path: rust/src/datatypes.rs
##########
@@ -87,8 +235,8 @@ mod tests {
use super::*;
#[test]
- fn test_define_schema() {
- let _person = Schema::new(vec![
+ fn create_struct_type() {
+ let _person = DataType::Struct(vec![
Review comment:
OK, though to what extent should we mirror
https://arrow.apache.org/docs/metadata.html?
That would make a `Schema` of `Field`s.
`Struct(Vec<Field>)` would go from a variant of `DataType` to defined as
`children` on a `Field`, whose type was only `Struct`?
(tbc these are low confidence and I'm only recently learning, so shoot me
down if I'm off)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [Rust] Implement to_json() for Field and DataType
> -------------------------------------------------
>
> Key: ARROW-2385
> URL: https://issues.apache.org/jira/browse/ARROW-2385
> Project: Apache Arrow
> Issue Type: New Feature
> Components: Rust
> Reporter: Andy Grove
> Assignee: Andy Grove
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.10.0
>
>
> Implementing JSON representation of DataType and Field as per Arrow
> specifications.
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
