[
https://issues.apache.org/jira/browse/ARROW-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16426568#comment-16426568
]
ASF GitHub Bot commented on ARROW-2397:
---------------------------------------
xhochy commented on a change in pull request #1837: ARROW-2397: [Documentation]
Update format documentation to describe tensor alignment.
URL: https://github.com/apache/arrow/pull/1837#discussion_r179371132
##########
File path: format/IPC.md
##########
@@ -240,8 +240,9 @@ tools. Arrow implementations in general are not required
to implement this data
format, though we provide a reference implementation in C++.
When writing a standalone encapsulated tensor message, we use the format as
-indicated above, but additionally align the starting offset (if writing to a
-shared memory region) to be a multiple of 8:
+indicated above, but additionally align the starting offset of the metadata as
+well as the starting offset of the tensor body (if writing to a shared memory
+region) to be multiples of 64 bytes:
Review comment:
From what we want we want as alignment in the Arrow standard, this is
correct. I don't know if all our implementations that emit tensors conform to
this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Document changes in Tensor encoding in IPC.md.
> ----------------------------------------------
>
> Key: ARROW-2397
> URL: https://issues.apache.org/jira/browse/ARROW-2397
> Project: Apache Arrow
> Issue Type: Improvement
> Components: Documentation
> Reporter: Robert Nishihara
> Priority: Major
> Labels: pull-request-available
>
> Update IPC.md to reflect the changes in
> https://github.com/apache/arrow/pull/1802.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
