[ 
https://issues.apache.org/jira/browse/ARROW-2404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16428295#comment-16428295
 ] 

ASF GitHub Bot commented on ARROW-2404:
---------------------------------------

xhochy closed pull request #1843: ARROW-2404: [C++] Fix "declaration of 
'type_id' hides class member" w…
URL: https://github.com/apache/arrow/pull/1843
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/cpp/src/arrow/type.h b/cpp/src/arrow/type.h
index 95f010a8f..ce213b999 100644
--- a/cpp/src/arrow/type.h
+++ b/cpp/src/arrow/type.h
@@ -437,8 +437,8 @@ class ARROW_EXPORT FixedSizeBinaryType : public 
FixedWidthType, public Parametri
 
   explicit FixedSizeBinaryType(int32_t byte_width)
       : FixedWidthType(Type::FIXED_SIZE_BINARY), byte_width_(byte_width) {}
-  explicit FixedSizeBinaryType(int32_t byte_width, Type::type type_id)
-      : FixedWidthType(type_id), byte_width_(byte_width) {}
+  explicit FixedSizeBinaryType(int32_t byte_width, Type::type override_type_id)
+      : FixedWidthType(override_type_id), byte_width_(byte_width) {}
 
   Status Accept(TypeVisitor* visitor) const override;
   std::string ToString() const override;


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Fix declaration of 'type_id' hides class member warning in msvc build
> ---------------------------------------------------------------------
>
>                 Key: ARROW-2404
>                 URL: https://issues.apache.org/jira/browse/ARROW-2404
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++
>         Environment: MSVC
>            Reporter: rip.nsk
>            Priority: Trivial
>              Labels: pull-request-available
>             Fix For: 0.10.0
>
>
> warning C4458: declaration of 'type_id' hides class member



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to