[
https://issues.apache.org/jira/browse/ARROW-2415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16429592#comment-16429592
]
ASF GitHub Bot commented on ARROW-2415:
---------------------------------------
waywardmonkeys commented on issue #1851: ARROW-2415: [Rust] Fix clippy
ref-match-pats warnings.
URL: https://github.com/apache/arrow/pull/1851#issuecomment-379516182
I'd planned to do subsequent things separately ... there's already a
separate issue + PR for the `format!` calls for example. That way, each set of
changes is independent and handled separately if people disagree on the
usefulness of a particular check.
Note that when `is_empty` is implemented for `Bitmap`, it should be
`self.bits.is_empty()` hopefully rather than `self.len != 0` ... but I had that
queued up for a subsequent issue + PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [Rust] Fix using references in pattern matching
> -----------------------------------------------
>
> Key: ARROW-2415
> URL: https://issues.apache.org/jira/browse/ARROW-2415
> Project: Apache Arrow
> Issue Type: Improvement
> Components: Rust
> Reporter: Bruce Mitchener
> Priority: Major
> Labels: pull-request-available
>
> Clippy reports
> [https://rust-lang-nursery.github.io/rust-clippy/v0.0.191/index.html#match_ref_pats]
> warnings.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
