[ 
https://issues.apache.org/jira/browse/ARROW-2305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16430753#comment-16430753
 ] 

ASF GitHub Bot commented on ARROW-2305:
---------------------------------------

pitrou closed pull request #1863: ARROW-2305: [Python] Bump Cython requirement 
to 0.27+
URL: https://github.com/apache/arrow/pull/1863
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/ci/msvc-build.bat b/ci/msvc-build.bat
index 678e29d58..d3f540b2d 100644
--- a/ci/msvc-build.bat
+++ b/ci/msvc-build.bat
@@ -68,10 +68,8 @@ if "%JOB%" == "Build_Debug" (
   exit /B 0
 )
 
-@rem Note: avoid Cython 0.28.0 due to 
https://github.com/cython/cython/issues/2148
 conda create -n arrow -q -y python=%PYTHON% ^
-      six pytest setuptools numpy pandas ^
-      cython=0.27.3 ^
+      six pytest setuptools numpy pandas cython ^
       thrift-cpp=0.11.0
 
 call activate arrow
diff --git a/ci/travis_script_python.sh b/ci/travis_script_python.sh
index aa3c3154c..a776c4263 100755
--- a/ci/travis_script_python.sh
+++ b/ci/travis_script_python.sh
@@ -36,13 +36,12 @@ source activate $CONDA_ENV_DIR
 python --version
 which python
 
-# Note: avoid Cython 0.28.0 due to https://github.com/cython/cython/issues/2148
 conda install -y -q pip \
       nomkl \
       cloudpickle \
       numpy=1.13.1 \
       pandas \
-      cython=0.27.3
+      cython
 
 # ARROW-2093: PyTorch increases the size of our conda dependency stack
 # significantly, and so we have disabled these tests in Travis CI for now
diff --git a/dev/release/verify-release-candidate.sh 
b/dev/release/verify-release-candidate.sh
index 34aff209a..ef058d172 100755
--- a/dev/release/verify-release-candidate.sh
+++ b/dev/release/verify-release-candidate.sh
@@ -104,7 +104,7 @@ setup_miniconda() {
         numpy \
         pandas \
         six \
-        cython=0.27.3 -c conda-forge
+        cython -c conda-forge
   source activate arrow-test
 }
 
diff --git a/python/manylinux1/scripts/build_virtualenvs.sh 
b/python/manylinux1/scripts/build_virtualenvs.sh
index 7e0d80cc7..a983721e9 100755
--- a/python/manylinux1/scripts/build_virtualenvs.sh
+++ b/python/manylinux1/scripts/build_virtualenvs.sh
@@ -34,7 +34,7 @@ for PYTHON_TUPLE in ${PYTHON_VERSIONS}; do
 
     echo "=== (${PYTHON}, ${U_WIDTH}) Installing build dependencies ==="
     $PIP install "numpy==1.10.4"
-    $PIP install "cython==0.27.3"
+    $PIP install "cython==0.28.1"
     $PIP install "pandas==0.20.3"
     $PIP install "virtualenv==15.1.0"
 
diff --git a/python/setup.py b/python/setup.py
index 7b0f17544..dd042c956 100644
--- a/python/setup.py
+++ b/python/setup.py
@@ -42,8 +42,8 @@
 # Check if we're running 64-bit Python
 is_64_bit = sys.maxsize > 2**32
 
-if Cython.__version__ < '0.19.1':
-    raise Exception('Please upgrade to Cython 0.19.1 or newer')
+if Cython.__version__ < '0.27':
+    raise Exception('Please upgrade to Cython 0.27 or newer')
 
 setup_dir = os.path.abspath(os.path.dirname(__file__))
 
@@ -491,7 +491,7 @@ def parse_version(root):
         ]
     },
     use_scm_version={"root": "..", "relative_to": __file__, "parse": 
parse_version},
-    setup_requires=['setuptools_scm', 'cython >= 0.23'] + setup_requires,
+    setup_requires=['setuptools_scm', 'cython >= 0.27'] + setup_requires,
     install_requires=install_requires,
     tests_require=['pytest', 'pandas'],
     description="Python library for Apache Arrow",


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [Python] Cython 0.25.2 compilation failure 
> -------------------------------------------
>
>                 Key: ARROW-2305
>                 URL: https://issues.apache.org/jira/browse/ARROW-2305
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: Python
>            Reporter: Wes McKinney
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 0.10.0
>
>
> Observed on master branch
> {code}
> Error compiling Cython file:
> ------------------------------------------------------------
> ...
>         if hasattr(self, 'as_py'):
>             return repr(self.as_py())
>         else:
>             return super(Scalar, self).__repr__()
>     def __eq__(self, other):
>    ^
> ------------------------------------------------------------
> /home/wesm/code/arrow/python/pyarrow/scalar.pxi:67:4: Special method __eq__ 
> must be implemented via __richcmp__
> Error compiling Cython file:
> ------------------------------------------------------------
> ...
>         Return true if the tensors contains exactly equal data
>         """
>         self._validate()
>         return self.tp.Equals(deref(other.tp))
>     def __eq__(self, other):
>    ^
> ------------------------------------------------------------
> /home/wesm/code/arrow/python/pyarrow/array.pxi:571:4: Special method __eq__ 
> must be implemented via __richcmp__
> Error compiling Cython file:
> ------------------------------------------------------------
> ...
>         cdef c_bool result = False
>         with nogil:
>             result = self.buffer.get().Equals(deref(other.buffer.get()))
>         return result
>     def __eq__(self, other):
>    ^
> ------------------------------------------------------------
> /home/wesm/code/arrow/python/pyarrow/io.pxi:675:4: Special method __eq__ must 
> be implemented via __richcmp__
> {code}
> Upgrading Cython made this go away. We should probably use {{__richcmp__}} 
> though



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to