[ 
https://issues.apache.org/jira/browse/ARROW-2425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16431915#comment-16431915
 ] 

ASF GitHub Bot commented on ARROW-2425:
---------------------------------------

xhochy closed pull request #1865: ARROW-2425: [Rust] BUG FIX: Add u8 mappings 
for Array::from
URL: https://github.com/apache/arrow/pull/1865
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/rust/src/array.rs b/rust/src/array.rs
index 09f0c9500..1b619d50b 100644
--- a/rust/src/array.rs
+++ b/rust/src/array.rs
@@ -123,6 +123,7 @@ macro_rules! array_from_primitive {
 array_from_primitive!(bool);
 array_from_primitive!(f32);
 array_from_primitive!(f64);
+array_from_primitive!(u8);
 array_from_primitive!(u16);
 array_from_primitive!(u32);
 array_from_primitive!(u64);
@@ -160,6 +161,7 @@ macro_rules! array_from_optional_primitive {
 array_from_optional_primitive!(bool, false);
 array_from_optional_primitive!(f32, 0_f32);
 array_from_optional_primitive!(f64, 0_f64);
+array_from_optional_primitive!(u8, 0_u8);
 array_from_optional_primitive!(u16, 0_u16);
 array_from_optional_primitive!(u32, 0_u32);
 array_from_optional_primitive!(u64, 0_u64);
diff --git a/rust/src/builder.rs b/rust/src/builder.rs
index 832b2a4a8..9915a8b52 100644
--- a/rust/src/builder.rs
+++ b/rust/src/builder.rs
@@ -18,6 +18,7 @@
 use libc;
 use std::mem;
 use std::ptr;
+use std::slice;
 
 use super::buffer::*;
 use super::memory::*;


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [Rust] Array::from missing mapping for u8 type
> ----------------------------------------------
>
>                 Key: ARROW-2425
>                 URL: https://issues.apache.org/jira/browse/ARROW-2425
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: Rust
>            Reporter: Andy Grove
>            Assignee: Andy Grove
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 0.10.0
>
>
> Macros are used to support Array::from for each primitive type but u8 was 
> missing



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to