ASF GitHub Bot commented on ARROW-2411:

xhochy commented on a change in pull request #1852: ARROW-2411: [C++] Add 
StringBuilder::Append(const char **values)
URL: https://github.com/apache/arrow/pull/1852#discussion_r180411014

 File path: cpp/src/arrow/builder.h
 @@ -720,6 +720,16 @@ class ARROW_EXPORT StringBuilder : public BinaryBuilder {
   Status Append(const std::vector<std::string>& values,
                 const uint8_t* valid_bytes = NULLPTR);
+  /// \brief Append a sequence of C strings in one shot
+  /// \param[in] values a contiguous C array of C strings
+  /// \param[in] length the number of values to append
+  /// \param[in] valid_bytes an optional sequence of bytes where non-zero
+  /// indicates a valid (non-null) value
+  /// \return Status
+  Status Append(const char** values,
 Review comment:
   I'm happy to have methods with better names. We should deprecate the old 
variants then and leave them in for one release. Removing methods completely 
between release without deprecation already creates a lot of overhead in the 
libraries consuming Arrow. While there are not that many public visible, I 
would like to keep maintenance for them as smooth as possible.

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> [C++] Add method to append batches of null-terminated strings to StringBuilder
> ------------------------------------------------------------------------------
>                 Key: ARROW-2411
>                 URL: https://issues.apache.org/jira/browse/ARROW-2411
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++, GLib
>            Reporter: Uwe L. Korn
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 0.10.0
> We should add a method {{StringBuilder::AppendCStrings(const char** values, 
> const uint8_t* valid_bytes = NULLPTR)}} to the {{StringBuilder}} class to 
> have fast inserts for these strings. See 
> https://github.com/apache/arrow/pull/1845/files for a use case.

This message was sent by Atlassian JIRA

Reply via email to