[
https://issues.apache.org/jira/browse/ARROW-2224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16432995#comment-16432995
]
Phillip Cloud edited comment on ARROW-2224 at 4/10/18 9:11 PM:
---------------------------------------------------------------
The original implementation used C++ iterators to implement a handwritten
parser, but it quickly got complex once we needed to support integers with
exponential notation. Maybe the complexity of dealing with boost is greater
than the complexity of debugging a handwritten parser, in which case it would
be worth it to reimplement it without a regular expression.
was (Author: cpcloud):
The original implementation used C++ to implement a handwritten parser, but it
quickly got complex once we needed to support integers with exponential
notation. Maybe the complexity of dealing with boost is greater than the
complexity of debugging a handwritten parser, in which case it would be worth
it to reimplement it without a regular expression.
> [C++] Replace boost regex usage with libre2
> -------------------------------------------
>
> Key: ARROW-2224
> URL: https://issues.apache.org/jira/browse/ARROW-2224
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++
> Reporter: Phillip Cloud
> Assignee: Phillip Cloud
> Priority: Major
>
> We're using {{boost::regex}} to parse decimal strings for {{decimal128}}
> types. We should use {{libre2}} instead.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
