ASF GitHub Bot commented on ARROW-2445:

andygrove commented on a change in pull request #1881: ARROW-2445: [Rust] Add 
documentation and make some fields private
URL: https://github.com/apache/arrow/pull/1881#discussion_r180766948

 File path: rust/src/array.rs
 @@ -69,10 +69,14 @@ arraydata_from_primitive!(u32, UInt32);
 arraydata_from_primitive!(u64, UInt64);
 pub struct Array {
-    pub len: i32,
-    pub null_count: i32,
-    pub validity_bitmap: Option<Bitmap>,
-    pub data: ArrayData,
+    /// number of elements in the array
+    len: i32,
+    /// number of null elements in the array
+    null_count: i32,
+    /// If null_count is greater than zero then the validity_bitmap will be 
+    validity_bitmap: Option<Bitmap>,
+    /// The array of elements
+    data: ArrayData,
 Review comment:
   Array is the physical memory storage and is separate from the meta-data 
describing the types.

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> [Rust] Add documentation and make some fields private
> -----------------------------------------------------
>                 Key: ARROW-2445
>                 URL: https://issues.apache.org/jira/browse/ARROW-2445
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: Rust
>            Reporter: Andy Grove
>            Assignee: Andy Grove
>            Priority: Trivial
>              Labels: pull-request-available
>             Fix For: 0.10.0
> A first pass at adding rustdoc comments and made some struct fields private 
> and added accessor methods.

This message was sent by Atlassian JIRA

Reply via email to