[ 
https://issues.apache.org/jira/browse/ARROW-2437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16436423#comment-16436423
 ] 

ASF GitHub Bot commented on ARROW-2437:
---------------------------------------

robertnishihara closed pull request #1874: ARROW-2437: [C++] Add ReadMessage 
without aligned argument.
URL: https://github.com/apache/arrow/pull/1874
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/cpp/src/arrow/ipc/message.cc b/cpp/src/arrow/ipc/message.cc
index 896221e71d..5173ae194b 100644
--- a/cpp/src/arrow/ipc/message.cc
+++ b/cpp/src/arrow/ipc/message.cc
@@ -248,6 +248,9 @@ Status ReadMessage(io::InputStream* file, 
std::unique_ptr<Message>* message,
   return Message::ReadFrom(metadata, file, message);
 }
 
+Status ReadMessage(io::InputStream* file, std::unique_ptr<Message>* message) {
+  return ReadMessage(file, message, false /* aligned */);
+}
 // ----------------------------------------------------------------------
 // Implement InputStream message reader
 
diff --git a/cpp/src/arrow/ipc/message.h b/cpp/src/arrow/ipc/message.h
index 4e0089b7d3..de195d49a7 100644
--- a/cpp/src/arrow/ipc/message.h
+++ b/cpp/src/arrow/ipc/message.h
@@ -183,7 +183,14 @@ Status ReadMessage(const int64_t offset, const int32_t 
metadata_length,
 /// in a stream)
 ARROW_EXPORT
 Status ReadMessage(io::InputStream* stream, std::unique_ptr<Message>* message,
-                   bool aligned = false);
+                   bool aligned);
+
+/// \brief Read encapulated RPC message (metadata and body) from InputStream.
+///
+/// This is a version of ReadMessage that does not have the aligned argument
+/// for backwards compatibility.
+ARROW_EXPORT
+Status ReadMessage(io::InputStream* stream, std::unique_ptr<Message>* message);
 
 }  // namespace ipc
 }  // namespace arrow


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [C++] Change of arrow::ipc::ReadMessage signature breaks ABI compability
> ------------------------------------------------------------------------
>
>                 Key: ARROW-2437
>                 URL: https://issues.apache.org/jira/browse/ARROW-2437
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: C++
>            Reporter: Uwe L. Korn
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: JS-0.4.0
>
>
> We changed the signature of the method from
> {code}
> ReadMessage ( arrow::io::InputStream* file, std::unique_ptr<message, 
> std::default_delete<Message> >* message ) 
> {code}
> to
> {code}
> ReadMessage ( arrow::io::InputStream* file, std::unique_ptr<message, 
> std::default_delete<Message> >* message, bool aligned ) 
> {code}
> We should add the old signature so that the 0.9.1 release is ABI compatible 
> to 0.9.0



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to