ASF GitHub Bot commented on ARROW-1780:

atuldambalkar commented on issue #1759: ARROW-1780 - [WIP] JDBC Adapter to 
convert Relational Data objects to Arrow Data Format Vector Objects
URL: https://github.com/apache/arrow/pull/1759#issuecomment-381014810
   Hi @laurentgo ,
   I have taken care of your following review comments -
   1. Used BaseAllocator instead of RootAllocator
   2. Added Calendar object as another argument to the API so that it gets used 
for Date, Time and Timestamp data values
   3. Handled NULL values for all the data types. I am basically using Nullable 
DataHolder objects as much as possible. Test cases need to be added though.
   4. For BigDecimal data type used getLong() API instead of getInt().
   5. Used StandardCharsets.UTF_8 as charset at places where we are doing 
string to bytes operation.
   Things that are still not done -
   1. I am unable to use the streaming approach for Blob and Clob as I couldn't 
figure out a way to really populate the Destination ArrowBuffer in a streaming 
   2. I still need to take care of the precision of Timestamp values for 
Nano/Micro/Milli values.
   3. Array data type is not yet supported.
   4. For the "default" switch case, the control shouldn't get there. So I 
could throw Exception if that makes sense.
   Let me know your comments.

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> JDBC Adapter for Apache Arrow
> -----------------------------
>                 Key: ARROW-1780
>                 URL: https://issues.apache.org/jira/browse/ARROW-1780
>             Project: Apache Arrow
>          Issue Type: New Feature
>            Reporter: Atul Dambalkar
>            Assignee: Atul Dambalkar
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 0.10.0
> At a high level the JDBC Adapter will allow upstream apps to query RDBMS data 
> over JDBC and get the JDBC objects converted to Arrow objects/structures. The 
> upstream utility can then work with Arrow objects/structures with usual 
> performance benefits. The utility will be very much similar to C++ 
> implementation of "Convert a vector of row-wise data into an Arrow table" as 
> described here - 
> https://arrow.apache.org/docs/cpp/md_tutorials_row_wise_conversion.html
> The utility will read data from RDBMS and covert the data into Arrow 
> objects/structures. So from that perspective this will Read data from RDBMS, 
> If the utility can push Arrow objects to RDBMS is something need to be 
> discussed and will be out of scope for this utility for now. 

This message was sent by Atlassian JIRA

Reply via email to