[
https://issues.apache.org/jira/browse/ARROW-2481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16445217#comment-16445217
]
ASF GitHub Bot commented on ARROW-2481:
---------------------------------------
paddyhoran commented on issue #1919: ARROW-2481: [Rust] Move all calls to
free() into memory.rs
URL: https://github.com/apache/arrow/pull/1919#issuecomment-382959256
+1 @andygrove , I was going to suggest this actually. Do we then want to
refactor memory_pool.rs to use memory.rs?
I think this is a good way to go, then we can keep all the OS specific logic
to one file. I guess we need to decide then whether we want other areas of the
code base to exclusively use memory_pool.rs (i.e. only memory_pool.rs should
use memory.rs)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [Rust] Move calls to free() into memory.rs
> ------------------------------------------
>
> Key: ARROW-2481
> URL: https://issues.apache.org/jira/browse/ARROW-2481
> Project: Apache Arrow
> Issue Type: Improvement
> Components: Rust
> Reporter: Andy Grove
> Assignee: Andy Grove
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.10.0
>
>
> We had calls to free memory in a few places, with duplication of effort for
> Windows support. This PR simply creates a free_aligned() method in memory.rs
> so we have all memory alloc/free and Windows references in a single file.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
