[ https://issues.apache.org/jira/browse/ARROW-2494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16447858#comment-16447858 ]
ASF GitHub Bot commented on ARROW-2494: --------------------------------------- pitrou commented on issue #1932: ARROW-2494: [C++] Return status codes from PlasmaClient::Seal instead of crashing URL: https://github.com/apache/arrow/pull/1932#issuecomment-383517652 When `ARROW_CHECK` checks for an internal invariant, we can keep it. But in other cases (such as non-existent object ID or IO error), it would be better to replace it with an error return, yes. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Return status codes from PlasmaClient::Seal > ------------------------------------------- > > Key: ARROW-2494 > URL: https://issues.apache.org/jira/browse/ARROW-2494 > Project: Apache Arrow > Issue Type: Sub-task > Components: C++ > Reporter: Krisztian Szucs > Assignee: Krisztian Szucs > Priority: Major > Labels: pull-request-available > -- This message was sent by Atlassian JIRA (v7.6.3#76005)