[
https://issues.apache.org/jira/browse/ARROW-2497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated ARROW-2497:
----------------------------------
Labels: pull-request-available (was: )
> Use ASSERT_NO_FATAIL_FAILURE in C++ unit tests
> ----------------------------------------------
>
> Key: ARROW-2497
> URL: https://issues.apache.org/jira/browse/ARROW-2497
> Project: Apache Arrow
> Issue Type: Improvement
> Reporter: Joshua Storck
> Priority: Minor
> Labels: pull-request-available
>
> A number of unit tests have helper functions that use gtest/arrow ASSERT_
> macros. Those ASSERT_ macros simply return out of the current context and do
> not throw exceptions or abort. Since these helper functions return void, the
> unit test simply continues when the assertions are triggered. This can lead
> to additional failures, such as segfaults because the test is executing code
> that it did not expect to. By adding the gtest ASSERT_NO_FATAIL_FAILURE to
> the calls of those helper functions in the outermost scope of the unit test,
> the test will correctly terminate.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
