[
https://issues.apache.org/jira/browse/ARROW-2499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16448767#comment-16448767
]
Phillip Cloud commented on ARROW-2499:
--------------------------------------
You'd still have to do the checks and choose the right _specific_ iterator but
in theory you'd be able to have a single {{VisitSequence(const
generic_iterator& iter)}} and loop over the elements using range-based for
loops, which gets rid of the loop duplication. I'm not sure how to get rid of
the checks since we only have {{PyObject*}} at the call site.
> [C++] Add iterator facility for Python sequences
> ------------------------------------------------
>
> Key: ARROW-2499
> URL: https://issues.apache.org/jira/browse/ARROW-2499
> Project: Apache Arrow
> Issue Type: Wish
> Components: C++
> Reporter: Antoine Pitrou
> Priority: Major
>
> The idea is to factor out something like the following:
> https://github.com/apache/arrow/pull/1935/files#diff-6ea0fcd65b95b76eab9ddfbd7a173725R78
> However I'm not sure which idiom or pattern we should choose. [~cpcloud] any
> idea?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
