[
https://issues.apache.org/jira/browse/ARROW-2708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16512996#comment-16512996
]
Anup Ghatage edited comment on ARROW-2708 at 6/14/18 9:14 PM:
--------------------------------------------------------------
Hi [~wesmckinn]!
I'd like to take this up.
I checked the mailing list
[here|https://mail-archives.apache.org/mod_mbox/arrow-issues/201806.mbox/browser]
but did not find any of the discussion.
Anyway, I was thinking of using ARROW_CHECK(data.buffers[i] == nullptr) for
validation.
In the case that 'buffers' is actually equal to nullptr, we must return
nullptr.
What do you think?
Apologies since I am out of the discussion loop and may have missed something
that was already discussed.
Regards,
Anup
was (Author: ghatageanup):
Hi [~wesmckinn]!
I'd like to take this up.
I checked the mailing list
[here|https://mail-archives.apache.org/mod_mbox/arrow-issues/201806.mbox/browser]
but did not find any of the discussion.
Anyway, I was thinking of using ARROW_CHECK(data.buffers[i], nullptr) for
validation.
In the case that 'buffers' is actually equal to nullptr, we must return nullptr.
What do you think?
Apologies since I am out of the discussion loop and may have missed something
that was already discussed.
Regards,
Anup
> [C++] Internal GetValues function in arrow::compute should check for nullptr
> ----------------------------------------------------------------------------
>
> Key: ARROW-2708
> URL: https://issues.apache.org/jira/browse/ARROW-2708
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++
> Reporter: Wes McKinney
> Priority: Major
>
> See
> https://github.com/apache/arrow/blob/master/cpp/src/arrow/compute/kernels/util-internal.h#L33
> and mailing list discussion
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
