[
https://issues.apache.org/jira/browse/ARROW-2720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16519228#comment-16519228
]
Wes McKinney commented on ARROW-2720:
-------------------------------------
Definitely would be good to use the CMAKE_* stuff where we have control over
it. We'll still have to pass -fPIC to some of the external projects, but we
could handle that in {{ThirdpartyToolchain.cmake}}
> [C++] Clean up cmake CXX_STANDARD and PIC flag setting
> ------------------------------------------------------
>
> Key: ARROW-2720
> URL: https://issues.apache.org/jira/browse/ARROW-2720
> Project: Apache Arrow
> Issue Type: Task
> Components: C++
> Reporter: Phillip Cloud
> Assignee: Phillip Cloud
> Priority: Major
> Fix For: 0.10.0
>
>
> We're using {{-std=c++11}} in a few non-external project places as well as
> setting {{-fPIC}}. CMake provides the {{CMAKE_CXX_STANDARD}} flag (which we
> are also using) and the {{CMAKE_POSITION_INDEPENDENT_CODE}} flag for setting
> these options in a cross platform way (where it matters).
> We should use these flags instead of using platform conditional checks to set
> their values explicitly.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)