[ 
https://issues.apache.org/jira/browse/ARROW-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16565512#comment-16565512
 ] 

Phillip Cloud commented on ARROW-2959:
--------------------------------------

I don't think that it's reasonable to expect contributors to maintain a cross 
platform shell script that cannot be guaranteed to be run from a single common 
point of origin.

For example, the script doesn't work if you're inside of a non-base conda 
environment that has ARROW_HOME set to CONDA_PREFIX.

I should be able to verify the release for common platforms without having to 
think about what environment variables I have set or what state my shell is in.

Yes, arrow is built and deployed in a number of places but AFAICT most people 
who run the release verification script are working on Ubuntu or OS X so we're 
not catching anything (or people are running it and running into bugs and not 
reporting it) now that we would not catch by moving to docker for this.

> Dockerize verify-release-candidate.{sh,bat}
> -------------------------------------------
>
>                 Key: ARROW-2959
>                 URL: https://issues.apache.org/jira/browse/ARROW-2959
>             Project: Apache Arrow
>          Issue Type: Task
>          Components: C++, Packaging
>    Affects Versions: 0.9.0
>            Reporter: Phillip Cloud
>            Priority: Major
>
> There are a number of issues with the linux version of this script that would 
> disappear if the commands were all being run in a docker container.
> Anyone with docker installed should be able to verify the release candidate
> We could probably do the same for windows as well.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to