[ https://issues.apache.org/jira/browse/ARROW-1176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16575157#comment-16575157 ]
Phillip Cloud commented on ARROW-1176: -------------------------------------- We'll probably want to use either {{string_view}} (or {{span}} if available) in abseil for this. There are some fairly nasty subtleties with {{string_view}} (and I would assume {{span}}) that are likely to cause us major headaches. Just some things to be aware of: # https://github.com/isocpp/CppCoreGuidelines/issues/1038#issuecomment-332404952 (and that whole thread) # https://foonathan.net/blog/2017/03/22/string_view-temporary.html > [C++] Replace WrappedBinary with Tensorflow's StringPiece > --------------------------------------------------------- > > Key: ARROW-1176 > URL: https://issues.apache.org/jira/browse/ARROW-1176 > Project: Apache Arrow > Issue Type: Improvement > Components: C++ > Reporter: Uwe L. Korn > Priority: Major > Fix For: 0.11.0 > > > Instead of using the very simple {{WrappedBinary}} class, we may want to use > Tensorflow's {{StringPiece}} to handle binary cells: > https://github.com/tensorflow/tensorflow/blob/master/tensorflow/core/lib/core/stringpiece.h -- This message was sent by Atlassian JIRA (v7.6.3#76005)