[ 
https://issues.apache.org/jira/browse/ARROW-3260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16619704#comment-16619704
 ] 

Wes McKinney commented on ARROW-3260:
-------------------------------------

Seems like having a more accessible pre-commit hook could help. I run the 
following code before every push to github

{code}
function arrow_preflight {
    ARROW_PREFLIGHT_DIR=$ARROW_ROOT/cpp/preflight-build
    mkdir -p $ARROW_PREFLIGHT_DIR
    pushd $ARROW_ROOT/cpp
    python build-support/lint_cpp_cli.py src || return
    popd
    pushd $ARROW_PREFLIGHT_DIR
    arrow_cmake
    ninja format
    ninja lint || return
    popd
    pushd $ARROW_ROOT/python
    flake8 --count pyarrow || return
    flake8 --count --config=.flake8.cython pyarrow || return
    popd
}
{code}

> [CI] Make linting a separate job
> --------------------------------
>
>                 Key: ARROW-3260
>                 URL: https://issues.apache.org/jira/browse/ARROW-3260
>             Project: Apache Arrow
>          Issue Type: Wish
>          Components: C++, Continuous Integration, Python
>            Reporter: Antoine Pitrou
>            Priority: Major
>
> When pushing changes I get routinely frustrated because Travis-CI fails early 
> on a linting failure. It would be nice if linting (Python, C++) was a 
> separate job so as not to disrupt the development workflow so much.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to