[
https://issues.apache.org/jira/browse/ARROW-3412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kouhei Sutou updated ARROW-3412:
--------------------------------
Description:
{code}
NOT APPROVED: cpp/cmake_modules/FindArrow.cmake
(apache-arrow-0.11.0/cpp/cmake_modules/FindArrow.cmake): false
NOT APPROVED: python/cmake_modules/FindFlatbuffers.cmake
(apache-arrow-0.11.0/python/cmake_modules/FindFlatbuffers.cmake): false
NOT APPROVED: python/cmake_modules/FindLz4.cmake
(apache-arrow-0.11.0/python/cmake_modules/FindLz4.cmake): false
NOT APPROVED: python/cmake_modules/FindNumPy.cmake
(apache-arrow-0.11.0/python/cmake_modules/FindNumPy.cmake): false
NOT APPROVED: python/cmake_modules/BuildUtils.cmake
(apache-arrow-0.11.0/python/cmake_modules/BuildUtils.cmake): false
NOT APPROVED: python/cmake_modules/SnappyCMakeLists.txt
(apache-arrow-0.11.0/python/cmake_modules/SnappyCMakeLists.txt): false
NOT APPROVED: python/cmake_modules/FindProtobuf.cmake
(apache-arrow-0.11.0/python/cmake_modules/FindProtobuf.cmake): false
NOT APPROVED: python/cmake_modules/FindLLVM.cmake
(apache-arrow-0.11.0/python/cmake_modules/FindLLVM.cmake): false
NOT APPROVED: python/cmake_modules/Findjemalloc.cmake
(apache-arrow-0.11.0/python/cmake_modules/Findjemalloc.cmake): false
NOT APPROVED: python/cmake_modules/SetupCxxFlags.cmake
(apache-arrow-0.11.0/python/cmake_modules/SetupCxxFlags.cmake): false
NOT APPROVED: python/cmake_modules/san-config.cmake
(apache-arrow-0.11.0/python/cmake_modules/san-config.cmake): false
NOT APPROVED: python/cmake_modules/FindGLOG.cmake
(apache-arrow-0.11.0/python/cmake_modules/FindGLOG.cmake): false
NOT APPROVED: python/cmake_modules/FindRE2.cmake
(apache-arrow-0.11.0/python/cmake_modules/FindRE2.cmake): false
NOT APPROVED: python/cmake_modules/FindArrowCuda.cmake
(apache-arrow-0.11.0/python/cmake_modules/FindArrowCuda.cmake): false
NOT APPROVED: python/cmake_modules/CompilerInfo.cmake
(apache-arrow-0.11.0/python/cmake_modules/CompilerInfo.cmake): false
NOT APPROVED: python/cmake_modules/FindArrow.cmake
(apache-arrow-0.11.0/python/cmake_modules/FindArrow.cmake): false
NOT APPROVED: python/cmake_modules/ThirdpartyToolchain.cmake
(apache-arrow-0.11.0/python/cmake_modules/ThirdpartyToolchain.cmake): false
NOT APPROVED: python/cmake_modules/FindSnappy.cmake
(apache-arrow-0.11.0/python/cmake_modules/FindSnappy.cmake): false
NOT APPROVED: python/cmake_modules/GandivaBuildUtils.cmake
(apache-arrow-0.11.0/python/cmake_modules/GandivaBuildUtils.cmake): false
NOT APPROVED: python/cmake_modules/FindZLIB.cmake
(apache-arrow-0.11.0/python/cmake_modules/FindZLIB.cmake): false
NOT APPROVED: python/cmake_modules/FindGTest.cmake
(apache-arrow-0.11.0/python/cmake_modules/FindGTest.cmake): false
NOT APPROVED: python/cmake_modules/UseCython.cmake
(apache-arrow-0.11.0/python/cmake_modules/UseCython.cmake): false
NOT APPROVED: python/cmake_modules/FindZSTD.cmake
(apache-arrow-0.11.0/python/cmake_modules/FindZSTD.cmake): false
NOT APPROVED: python/cmake_modules/FindPlasma.cmake
(apache-arrow-0.11.0/python/cmake_modules/FindPlasma.cmake): false
NOT APPROVED: python/cmake_modules/FindBrotli.cmake
(apache-arrow-0.11.0/python/cmake_modules/FindBrotli.cmake): false
NOT APPROVED: python/cmake_modules/FindPythonLibsNew.cmake
(apache-arrow-0.11.0/python/cmake_modules/FindPythonLibsNew.cmake): false
NOT APPROVED: python/cmake_modules/FindThrift.cmake
(apache-arrow-0.11.0/python/cmake_modules/FindThrift.cmake): false
NOT APPROVED: python/cmake_modules/FindParquet.cmake
(apache-arrow-0.11.0/python/cmake_modules/FindParquet.cmake): false
NOT APPROVED: python/cmake_modules/FindClangTools.cmake
(apache-arrow-0.11.0/python/cmake_modules/FindClangTools.cmake): false
NOT APPROVED: python/cmake_modules/FindInferTools.cmake
(apache-arrow-0.11.0/python/cmake_modules/FindInferTools.cmake): false
NOT APPROVED: python/cmake_modules/FindGFlags.cmake
(apache-arrow-0.11.0/python/cmake_modules/FindGFlags.cmake): false
NOT APPROVED: python/cmake_modules/FindGBenchmark.cmake
(apache-arrow-0.11.0/python/cmake_modules/FindGBenchmark.cmake): false
NOT APPROVED: python/cmake_modules/FindGPerf.cmake
(apache-arrow-0.11.0/python/cmake_modules/FindGPerf.cmake): false
NOT APPROVED: python/cmake_modules/SnappyConfig.h
(apache-arrow-0.11.0/python/cmake_modules/SnappyConfig.h): false
NOT APPROVED: c_glib/doc/arrow-glib/arrow-glib.types
(apache-arrow-0.11.0/c_glib/doc/arrow-glib/arrow-glib.types): false
NOT APPROVED: c_glib/doc/arrow-glib/arrow-glib-sections.txt
(apache-arrow-0.11.0/c_glib/doc/arrow-glib/arrow-glib-sections.txt): false
NOT APPROVED: c_glib/doc/arrow-glib/arrow-glib-overrides.txt
(apache-arrow-0.11.0/c_glib/doc/arrow-glib/arrow-glib-overrides.txt): false
{code}
was:
{{monospaced}}
NOT APPROVED: cpp/cmake_modules/FindArrow.cmake
(apache-arrow-0.11.0/cpp/cmake_modules/FindArrow.cmake): false
NOT APPROVED: python/cmake_modules/FindFlatbuffers.cmake
(apache-arrow-0.11.0/python/cmake_modules/FindFlatbuffers.cmake): false
NOT APPROVED: python/cmake_modules/FindLz4.cmake
(apache-arrow-0.11.0/python/cmake_modules/FindLz4.cmake): false
NOT APPROVED: python/cmake_modules/FindNumPy.cmake
(apache-arrow-0.11.0/python/cmake_modules/FindNumPy.cmake): false
NOT APPROVED: python/cmake_modules/BuildUtils.cmake
(apache-arrow-0.11.0/python/cmake_modules/BuildUtils.cmake): false
NOT APPROVED: python/cmake_modules/SnappyCMakeLists.txt
(apache-arrow-0.11.0/python/cmake_modules/SnappyCMakeLists.txt): false
NOT APPROVED: python/cmake_modules/FindProtobuf.cmake
(apache-arrow-0.11.0/python/cmake_modules/FindProtobuf.cmake): false
NOT APPROVED: python/cmake_modules/FindLLVM.cmake
(apache-arrow-0.11.0/python/cmake_modules/FindLLVM.cmake): false
NOT APPROVED: python/cmake_modules/Findjemalloc.cmake
(apache-arrow-0.11.0/python/cmake_modules/Findjemalloc.cmake): false
NOT APPROVED: python/cmake_modules/SetupCxxFlags.cmake
(apache-arrow-0.11.0/python/cmake_modules/SetupCxxFlags.cmake): false
NOT APPROVED: python/cmake_modules/san-config.cmake
(apache-arrow-0.11.0/python/cmake_modules/san-config.cmake): false
NOT APPROVED: python/cmake_modules/FindGLOG.cmake
(apache-arrow-0.11.0/python/cmake_modules/FindGLOG.cmake): false
NOT APPROVED: python/cmake_modules/FindRE2.cmake
(apache-arrow-0.11.0/python/cmake_modules/FindRE2.cmake): false
NOT APPROVED: python/cmake_modules/FindArrowCuda.cmake
(apache-arrow-0.11.0/python/cmake_modules/FindArrowCuda.cmake): false
NOT APPROVED: python/cmake_modules/CompilerInfo.cmake
(apache-arrow-0.11.0/python/cmake_modules/CompilerInfo.cmake): false
NOT APPROVED: python/cmake_modules/FindArrow.cmake
(apache-arrow-0.11.0/python/cmake_modules/FindArrow.cmake): false
NOT APPROVED: python/cmake_modules/ThirdpartyToolchain.cmake
(apache-arrow-0.11.0/python/cmake_modules/ThirdpartyToolchain.cmake): false
NOT APPROVED: python/cmake_modules/FindSnappy.cmake
(apache-arrow-0.11.0/python/cmake_modules/FindSnappy.cmake): false
NOT APPROVED: python/cmake_modules/GandivaBuildUtils.cmake
(apache-arrow-0.11.0/python/cmake_modules/GandivaBuildUtils.cmake): false
NOT APPROVED: python/cmake_modules/FindZLIB.cmake
(apache-arrow-0.11.0/python/cmake_modules/FindZLIB.cmake): false
NOT APPROVED: python/cmake_modules/FindGTest.cmake
(apache-arrow-0.11.0/python/cmake_modules/FindGTest.cmake): false
NOT APPROVED: python/cmake_modules/UseCython.cmake
(apache-arrow-0.11.0/python/cmake_modules/UseCython.cmake): false
NOT APPROVED: python/cmake_modules/FindZSTD.cmake
(apache-arrow-0.11.0/python/cmake_modules/FindZSTD.cmake): false
NOT APPROVED: python/cmake_modules/FindPlasma.cmake
(apache-arrow-0.11.0/python/cmake_modules/FindPlasma.cmake): false
NOT APPROVED: python/cmake_modules/FindBrotli.cmake
(apache-arrow-0.11.0/python/cmake_modules/FindBrotli.cmake): false
NOT APPROVED: python/cmake_modules/FindPythonLibsNew.cmake
(apache-arrow-0.11.0/python/cmake_modules/FindPythonLibsNew.cmake): false
NOT APPROVED: python/cmake_modules/FindThrift.cmake
(apache-arrow-0.11.0/python/cmake_modules/FindThrift.cmake): false
NOT APPROVED: python/cmake_modules/FindParquet.cmake
(apache-arrow-0.11.0/python/cmake_modules/FindParquet.cmake): false
NOT APPROVED: python/cmake_modules/FindClangTools.cmake
(apache-arrow-0.11.0/python/cmake_modules/FindClangTools.cmake): false
NOT APPROVED: python/cmake_modules/FindInferTools.cmake
(apache-arrow-0.11.0/python/cmake_modules/FindInferTools.cmake): false
NOT APPROVED: python/cmake_modules/FindGFlags.cmake
(apache-arrow-0.11.0/python/cmake_modules/FindGFlags.cmake): false
NOT APPROVED: python/cmake_modules/FindGBenchmark.cmake
(apache-arrow-0.11.0/python/cmake_modules/FindGBenchmark.cmake): false
NOT APPROVED: python/cmake_modules/FindGPerf.cmake
(apache-arrow-0.11.0/python/cmake_modules/FindGPerf.cmake): false
NOT APPROVED: python/cmake_modules/SnappyConfig.h
(apache-arrow-0.11.0/python/cmake_modules/SnappyConfig.h): false
NOT APPROVED: c_glib/doc/arrow-glib/arrow-glib.types
(apache-arrow-0.11.0/c_glib/doc/arrow-glib/arrow-glib.types): false
NOT APPROVED: c_glib/doc/arrow-glib/arrow-glib-sections.txt
(apache-arrow-0.11.0/c_glib/doc/arrow-glib/arrow-glib-sections.txt): false
NOT APPROVED: c_glib/doc/arrow-glib/arrow-glib-overrides.txt
(apache-arrow-0.11.0/c_glib/doc/arrow-glib/arrow-glib-overrides.txt): false
{{monospaced}}
> [Packaging] rat failure in dev/release/02-source.sh
> ---------------------------------------------------
>
> Key: ARROW-3412
> URL: https://issues.apache.org/jira/browse/ARROW-3412
> Project: Apache Arrow
> Issue Type: Improvement
> Components: Packaging
> Reporter: Kouhei Sutou
> Priority: Major
>
> {code}
> NOT APPROVED: cpp/cmake_modules/FindArrow.cmake
> (apache-arrow-0.11.0/cpp/cmake_modules/FindArrow.cmake): false
> NOT APPROVED: python/cmake_modules/FindFlatbuffers.cmake
> (apache-arrow-0.11.0/python/cmake_modules/FindFlatbuffers.cmake): false
> NOT APPROVED: python/cmake_modules/FindLz4.cmake
> (apache-arrow-0.11.0/python/cmake_modules/FindLz4.cmake): false
> NOT APPROVED: python/cmake_modules/FindNumPy.cmake
> (apache-arrow-0.11.0/python/cmake_modules/FindNumPy.cmake): false
> NOT APPROVED: python/cmake_modules/BuildUtils.cmake
> (apache-arrow-0.11.0/python/cmake_modules/BuildUtils.cmake): false
> NOT APPROVED: python/cmake_modules/SnappyCMakeLists.txt
> (apache-arrow-0.11.0/python/cmake_modules/SnappyCMakeLists.txt): false
> NOT APPROVED: python/cmake_modules/FindProtobuf.cmake
> (apache-arrow-0.11.0/python/cmake_modules/FindProtobuf.cmake): false
> NOT APPROVED: python/cmake_modules/FindLLVM.cmake
> (apache-arrow-0.11.0/python/cmake_modules/FindLLVM.cmake): false
> NOT APPROVED: python/cmake_modules/Findjemalloc.cmake
> (apache-arrow-0.11.0/python/cmake_modules/Findjemalloc.cmake): false
> NOT APPROVED: python/cmake_modules/SetupCxxFlags.cmake
> (apache-arrow-0.11.0/python/cmake_modules/SetupCxxFlags.cmake): false
> NOT APPROVED: python/cmake_modules/san-config.cmake
> (apache-arrow-0.11.0/python/cmake_modules/san-config.cmake): false
> NOT APPROVED: python/cmake_modules/FindGLOG.cmake
> (apache-arrow-0.11.0/python/cmake_modules/FindGLOG.cmake): false
> NOT APPROVED: python/cmake_modules/FindRE2.cmake
> (apache-arrow-0.11.0/python/cmake_modules/FindRE2.cmake): false
> NOT APPROVED: python/cmake_modules/FindArrowCuda.cmake
> (apache-arrow-0.11.0/python/cmake_modules/FindArrowCuda.cmake): false
> NOT APPROVED: python/cmake_modules/CompilerInfo.cmake
> (apache-arrow-0.11.0/python/cmake_modules/CompilerInfo.cmake): false
> NOT APPROVED: python/cmake_modules/FindArrow.cmake
> (apache-arrow-0.11.0/python/cmake_modules/FindArrow.cmake): false
> NOT APPROVED: python/cmake_modules/ThirdpartyToolchain.cmake
> (apache-arrow-0.11.0/python/cmake_modules/ThirdpartyToolchain.cmake): false
> NOT APPROVED: python/cmake_modules/FindSnappy.cmake
> (apache-arrow-0.11.0/python/cmake_modules/FindSnappy.cmake): false
> NOT APPROVED: python/cmake_modules/GandivaBuildUtils.cmake
> (apache-arrow-0.11.0/python/cmake_modules/GandivaBuildUtils.cmake): false
> NOT APPROVED: python/cmake_modules/FindZLIB.cmake
> (apache-arrow-0.11.0/python/cmake_modules/FindZLIB.cmake): false
> NOT APPROVED: python/cmake_modules/FindGTest.cmake
> (apache-arrow-0.11.0/python/cmake_modules/FindGTest.cmake): false
> NOT APPROVED: python/cmake_modules/UseCython.cmake
> (apache-arrow-0.11.0/python/cmake_modules/UseCython.cmake): false
> NOT APPROVED: python/cmake_modules/FindZSTD.cmake
> (apache-arrow-0.11.0/python/cmake_modules/FindZSTD.cmake): false
> NOT APPROVED: python/cmake_modules/FindPlasma.cmake
> (apache-arrow-0.11.0/python/cmake_modules/FindPlasma.cmake): false
> NOT APPROVED: python/cmake_modules/FindBrotli.cmake
> (apache-arrow-0.11.0/python/cmake_modules/FindBrotli.cmake): false
> NOT APPROVED: python/cmake_modules/FindPythonLibsNew.cmake
> (apache-arrow-0.11.0/python/cmake_modules/FindPythonLibsNew.cmake): false
> NOT APPROVED: python/cmake_modules/FindThrift.cmake
> (apache-arrow-0.11.0/python/cmake_modules/FindThrift.cmake): false
> NOT APPROVED: python/cmake_modules/FindParquet.cmake
> (apache-arrow-0.11.0/python/cmake_modules/FindParquet.cmake): false
> NOT APPROVED: python/cmake_modules/FindClangTools.cmake
> (apache-arrow-0.11.0/python/cmake_modules/FindClangTools.cmake): false
> NOT APPROVED: python/cmake_modules/FindInferTools.cmake
> (apache-arrow-0.11.0/python/cmake_modules/FindInferTools.cmake): false
> NOT APPROVED: python/cmake_modules/FindGFlags.cmake
> (apache-arrow-0.11.0/python/cmake_modules/FindGFlags.cmake): false
> NOT APPROVED: python/cmake_modules/FindGBenchmark.cmake
> (apache-arrow-0.11.0/python/cmake_modules/FindGBenchmark.cmake): false
> NOT APPROVED: python/cmake_modules/FindGPerf.cmake
> (apache-arrow-0.11.0/python/cmake_modules/FindGPerf.cmake): false
> NOT APPROVED: python/cmake_modules/SnappyConfig.h
> (apache-arrow-0.11.0/python/cmake_modules/SnappyConfig.h): false
> NOT APPROVED: c_glib/doc/arrow-glib/arrow-glib.types
> (apache-arrow-0.11.0/c_glib/doc/arrow-glib/arrow-glib.types): false
> NOT APPROVED: c_glib/doc/arrow-glib/arrow-glib-sections.txt
> (apache-arrow-0.11.0/c_glib/doc/arrow-glib/arrow-glib-sections.txt): false
> NOT APPROVED: c_glib/doc/arrow-glib/arrow-glib-overrides.txt
> (apache-arrow-0.11.0/c_glib/doc/arrow-glib/arrow-glib-overrides.txt): false
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
