[ 
https://issues.apache.org/jira/browse/ARROW-3701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16675008#comment-16675008
 ] 

Pindikura Ravindra edited comment on ARROW-3701 at 11/5/18 11:42 AM:
---------------------------------------------------------------------

> CPUs generally don't have 128 bit integer support. So any code written using 
> a "int128" -

> which is non-standard - will get  translated into 64-bit instructions at the 
> CPU level.

I'm assuming the compilers are more efficient at this, but I may be wrong.

[https://github.com/rust-lang/rfcs/blob/master/text/1504-int128.md#alternatives]

With my initial testing for adding decimals -  the perf with adding i128 is 
very good (almost same as adding three longs). I haven't tried doing the same 
with the current Decimal128 - let me give it a try.


was (Author: pravindra):
> CPUs generally don't have 128 bit integer support. So any code written using 
> a "int128" - which is non-standard - will get > translated into 64-bit 
> instructions at the CPU level.

I'm assuming the compilers are more efficient at this, but I may be wrong.

[https://github.com/rust-lang/rfcs/blob/master/text/1504-int128.md#alternatives]

With my initial testing for adding decimals -  the perf with adding i128 is 
very good (almost same as adding three longs). I haven't tried doing the same 
with the current Decimal128 - let me give it a try.

> [Gandiva] Add support for decimal operations
> --------------------------------------------
>
>                 Key: ARROW-3701
>                 URL: https://issues.apache.org/jira/browse/ARROW-3701
>             Project: Apache Arrow
>          Issue Type: Task
>          Components: Gandiva
>            Reporter: Pindikura Ravindra
>            Assignee: Pindikura Ravindra
>            Priority: Major
>
> To begin with, will add support for 128-bit decimals. There are two parts :
>  # llvm_generator needs to understand decimal types (value, precision, scale)
>  # code decimal operations : add/subtract/multiply/divide/mod/..
>  ** This will be c++ code that can be pre-compiled to emit IR code



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to