[
https://issues.apache.org/jira/browse/ARROW-3778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16685666#comment-16685666
]
Wes McKinney commented on ARROW-3778:
-------------------------------------
Agreed. I had partly done this in https://github.com/apache/arrow/pull/2704, so
if you wanted to use just the arrow/util/testing.h/testing.cc changes from
there go ahead
> [C++] Don't put implementations in test-util.h
> ----------------------------------------------
>
> Key: ARROW-3778
> URL: https://issues.apache.org/jira/browse/ARROW-3778
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++
> Affects Versions: 0.11.1
> Reporter: Antoine Pitrou
> Priority: Major
>
> {{test-util.h}} is included in most (all?) test files, and it's quite long to
> compile because it includes many other files and recompiles helper functions
> all the time. Instead we should have only declarations in {{test-util.h}} and
> put implementations in a separate {{.cc}} file.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
