[
https://issues.apache.org/jira/browse/ARROW-3169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16702089#comment-16702089
]
Antoine Pitrou edited comment on ARROW-3169 at 11/28/18 5:25 PM:
-----------------------------------------------------------------
{{builder.cc}} is also a good candidate for splitting up (recompiling it takes
several seconds here).
was (Author: pitrou):
{\{builder.cc} is also a good candidate for splitting up (recompiling it takes
several seconds here).
> [C++] Break array-test.cc and array.cc into multiple compilation units
> ----------------------------------------------------------------------
>
> Key: ARROW-3169
> URL: https://issues.apache.org/jira/browse/ARROW-3169
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++
> Reporter: Wes McKinney
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.13.0
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> To improve readability I suggest splitting array-test.cc into multiple
> compilation units (which will still be linked into an executable
> {{array-test}}). We can do the same thing with array.h/array.cc, while
> maintaining the {{arrow/array.h}} public header. Some of these could go into
> {{arrow/columnar}} or {{arrow/impl}}, or something similar.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
