[
https://issues.apache.org/jira/browse/ARROW-3906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16703392#comment-16703392
]
Wes McKinney commented on ARROW-3906:
-------------------------------------
Sounds fine to me. I think it could be useful to have a subdirectory to collect
implementation h / cc files. This could be called columnar / or array/ or
similar.
> [C++] Break builder.cc into multiple compilation units
> ------------------------------------------------------
>
> Key: ARROW-3906
> URL: https://issues.apache.org/jira/browse/ARROW-3906
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++
> Affects Versions: 0.11.1
> Reporter: Antoine Pitrou
> Priority: Major
>
> To improve readability I suggest splitting {{builder.cc}} into independent
> compilation units. Concrete builder classes are generally independent of each
> other. The only concern is whether inlining some of the base class
> implementations is important for performance.
> This would also make incremental compilation faster when changing one of the
> concrete classes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
