[
https://issues.apache.org/jira/browse/ARROW-3923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16705949#comment-16705949
]
Michael Pigott commented on ARROW-3923:
---------------------------------------
Pull Request: https://github.com/apache/arrow/pull/3066
> [Java] JDBC-to-Arrow Conversion: Unnecessary Calendar Requirement
> -----------------------------------------------------------------
>
> Key: ARROW-3923
> URL: https://issues.apache.org/jira/browse/ARROW-3923
> Project: Apache Arrow
> Issue Type: Bug
> Components: Java
> Reporter: Michael Pigott
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> While I was going through the JDBC Adapter source code, I noticed a Calendar
> was required to create the Arrow Schema (for any Timestamp fields), and also
> needed for converting a JDBC ResultSet to an ArrowVector (for Date, Time, and
> Timestamp fields).
> However, Arrow Timestamps do not require a time zone, and none of the JDBC
> getters for Date, Time, and Timestamp require a Calendar.
> I am proposing a change to make the Schema creator and ResultSet converter
> support null Calendars. If a Calendar is available, it will be used, and if
> not, it will not be used.
> The existing SureFire plugin configuration uses a UTC calendar for the
> database, which is the default Calendar in the existing code. Likewise, no
> changes to the unit tests are required to provide adequate coverage for the
> change.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
