[ 
https://issues.apache.org/jira/browse/ARROW-4264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16754593#comment-16754593
 ] 

Micah Kornfield commented on ARROW-4264:
----------------------------------------

There was disagreeing feedback between [~fsaintjacques] and [~wesmckinn] on 
whether this might be desirable.

 

 

I think the issue might be how arrow-programmer errors should be handled.  
DCHECK can in the extreme crash the program, this might not be desirable in the 
context of multi-tenant software.  I would lean slightly towards returning a 
Status but can see an argument for both.

> [C++] Convert DCHECKs in that check compute/* input parameters to error 
> statuses
> --------------------------------------------------------------------------------
>
>                 Key: ARROW-4264
>                 URL: https://issues.apache.org/jira/browse/ARROW-4264
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: C++
>            Reporter: Micah Kornfield
>            Assignee: Micah Kornfield
>            Priority: Minor
>
> DCHECKs seem to be used where Status::Invalid is more appropriate (so 
> programs don't crash).  See conversation on 
> https://github.com/apache/arrow/pull/3287/files



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to