[
https://issues.apache.org/jira/browse/ARROW-4447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16758511#comment-16758511
]
Kevin Gurney edited comment on ARROW-4447 at 2/1/19 10:00 PM:
--------------------------------------------------------------
It looks like changes to support building libthrift as a shared library on
Windows were only recently introduced in
[https://github.com/apache/thrift/commit/278528cf7b1dd5dd977bce882aa126fac8695697]
through the use of CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS (as opposed to explicit
usage of __declspec(dllexport)).
Therefore, it seems that supporting dynamic linking would require a version
bump for Arrow's libthrift dependency to the latest upstream Thrift code beyond
stable release 0.12.0.
Refer to https://issues.apache.org/jira/browse/THRIFT-1834 for further
discussion.
was (Author: kgurney):
It looks like changes to support building libthrift as a shared library on
Windows were only recently introduced in
https://github.com/apache/thrift/commit/278528cf7b1dd5dd977bce882aa126fac8695697
through the use of CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS (as opposed to explicit
usage of __declspec(dllexport)).
Therefore, it seems that supporting dynamic linking would require a version
bump for Arrow's libthrift dependency to the latest upstream Thrift code beyond
stable release 0.12.0.
> [C++] Investigate dynamic linking for libthift
> ----------------------------------------------
>
> Key: ARROW-4447
> URL: https://issues.apache.org/jira/browse/ARROW-4447
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++
> Reporter: Uwe L. Korn
> Priority: Major
> Fix For: 0.13.0
>
>
> We're currently only linking statically against {{libthrift}} . Distributions
> would often prefer a dynamic linkage to libraries where possible.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
