[ 
https://issues.apache.org/jira/browse/ARROW-1266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16761440#comment-16761440
 ] 

Philipp Moritz commented on ARROW-1266:
---------------------------------------

At a quick glance, the only structure that is still allocated with new is 
GetRequest here: 
[https://github.com/apache/arrow/blob/0c55b25c84119af59320eab0b0625da9ce987294/cpp/src/plasma/store.cc#L404]

The control flow is pretty clear and it is deleted here: 
[https://github.com/apache/arrow/blob/0c55b25c84119af59320eab0b0625da9ce987294/cpp/src/plasma/store.cc#L296]

However if somebody wants to make it a unique_ptr or shared_ptr ([~suquark]?) I 
wouldn't mind.

> [Plasma] Move heap allocations to arrow memory pool
> ---------------------------------------------------
>
>                 Key: ARROW-1266
>                 URL: https://issues.apache.org/jira/browse/ARROW-1266
>             Project: Apache Arrow
>          Issue Type: Bug
>            Reporter: Philipp Moritz
>            Priority: Major
>             Fix For: 0.13.0
>
>
> At the moment we are allocating memory with std::vectors and even new in some 
> places, this should be cleaned up.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to