[ 
https://issues.apache.org/jira/browse/ARROW-4264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Micah Kornfield updated ARROW-4264:
-----------------------------------
    Description: 
DCHECKs seem to be used where Status::Invalid might be considered more 
appropriate (so programs don't crash).  See conversation on 
[https://github.com/apache/arrow/pull/3287/files]

based on conversation on this Jira and on the CL it seems DCHECKS are in fact 
desired but we should document appropriate use for them.

  was:DCHECKs seem to be used where Status::Invalid is more appropriate (so 
programs don't crash).  See conversation on 
https://github.com/apache/arrow/pull/3287/files


> [C++] Document why DCHECKs are used in kernels
> ----------------------------------------------
>
>                 Key: ARROW-4264
>                 URL: https://issues.apache.org/jira/browse/ARROW-4264
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: C++
>            Reporter: Micah Kornfield
>            Assignee: Micah Kornfield
>            Priority: Minor
>
> DCHECKs seem to be used where Status::Invalid might be considered more 
> appropriate (so programs don't crash).  See conversation on 
> [https://github.com/apache/arrow/pull/3287/files]
> based on conversation on this Jira and on the CL it seems DCHECKS are in fact 
> desired but we should document appropriate use for them.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to