[ https://issues.apache.org/jira/browse/ARROW-4520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Kietzman updated ARROW-4520: ------------------------------------- Description: For release builds, {{DCHECK( x ) << y << z;}} currently expands to {code} ((void)(x)); while (false) ::arrow::util::ArrowLogBase() << y << z; {code} This is unreachable and which is an error using clang-7 was: For release builds, {{DCHECK(x) << y << z;}} currently expands to {code} ((void)(x)); while (false) ::arrow::util::ArrowLogBase() << y << z; {code} This is unreachable and which is an error using clang-7 > [C++] DCHECK custom messages are unreachable in release > ------------------------------------------------------- > > Key: ARROW-4520 > URL: https://issues.apache.org/jira/browse/ARROW-4520 > Project: Apache Arrow > Issue Type: Bug > Components: C++ > Reporter: Benjamin Kietzman > Assignee: Benjamin Kietzman > Priority: Major > > For release builds, {{DCHECK( x ) << y << z;}} currently expands to > {code} > ((void)(x)); > while (false) ::arrow::util::ArrowLogBase() << y << z; > {code} > This is unreachable and which is an error using clang-7 -- This message was sent by Atlassian JIRA (v7.6.3#76005)