[
https://issues.apache.org/jira/browse/ARROW-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16772352#comment-16772352
]
Nicolas Trinquier edited comment on ARROW-4605 at 2/19/19 9:33 PM:
-------------------------------------------------------------------
[filter|https://github.com/apache/arrow/blob/a65798a0ed3a96cfcd765e84615321da25ae17c8/rust/datafusion/src/execution/filter.rs#L89]
has already the signature you suggest [~nevi_me].
However for limit it is only a usize, not an array of bools, so I initially
suggested to have one function to do both filter and limit, with the signature
signature:
filter(a: &Array, predicate: Fn(usize) -> bool) -> Result<ArrayRef>
but on second though I am not sure this is worth it because of the performance
implications. We might be better off using macros. What do you think?
was (Author: ntrinquier):
[filter|https://github.com/apache/arrow/blob/a65798a0ed3a96cfcd765e84615321da25ae17c8/rust/datafusion/src/execution/filter.rs#L89]
has already the signature you suggest [~nevi_me].
However for limit it is only a usize, not an array of bools, so I initially
suggested to have a common signature:
filter(a: &Array, predicate: Fn(usize) -> bool) -> Result<ArrayRef>
but on second though I am not sure this is worth it because of the performance
implications. We might be better off using macros. What do you think?
> [Rust] Move filter and limit code from DataFusion into compute module
> ---------------------------------------------------------------------
>
> Key: ARROW-4605
> URL: https://issues.apache.org/jira/browse/ARROW-4605
> Project: Apache Arrow
> Issue Type: Improvement
> Components: Rust
> Affects Versions: 0.12.0
> Reporter: Andy Grove
> Priority: Major
> Fix For: 0.13.0
>
>
> FilterRelation and the new LimitRelation (in ARROW-4464) contain code for
> filtering and limiting arrays that could now be pushed down into the compute
> module.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
