[
https://issues.apache.org/jira/browse/ARROW-4725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16781511#comment-16781511
]
Antoine Pitrou commented on ARROW-4725:
---------------------------------------
Unfortunately, "if(WIN32)" will probably disable the tests also on MSVC, which
it shouldn't :-(
[~wesmckinn]
> [C++] Dictionary tests disabled under MinGW builds
> --------------------------------------------------
>
> Key: ARROW-4725
> URL: https://issues.apache.org/jira/browse/ARROW-4725
> Project: Apache Arrow
> Issue Type: Test
> Components: C++
> Reporter: Javier Luraschi
> Priority: Major
>
> Follow up to needed for
> [arrow/pull/3693/files|https://github.com/apache/arrow/pull/3693/files].
> Under cpp/src/arrow/CMakeLists.txt, PR disabled array-dict-test.cc test, by
> adding:
>
> {code:java}
> if(WIN32)
> add_arrow_test(array-test
> SOURCES
> array-test.cc
> array-binary-test.cc
> array-list-test.cc
> array-struct-test.cc)
> else()
> add_arrow_test(array-test
> SOURCES
> array-test.cc
> array-binary-test.cc
> array-dict-test.cc
> array-list-test.cc
> array-struct-test.cc)
> endif(){code}
>
> Which should be reverted and investigated further. The build error that
> including this test triggers is the following:
> {code:java}
> /arrow-array-test.dir/objects.a(array-dict-test.cc.obj):array-dict-test.cc:(.text+0xb9a2):
> undefined reference to
> `arrow::DictionaryBuilder<arrow::FixedSizeBinaryType>::DictionaryBuilder(std::shared_ptr<arrow::DataType>
> const&, arrow::MemoryPool*)'
> CMakeFiles/arrow-array-test.dir/objects.a(array-dict-test.cc.obj):array-dict-test.cc:(.text+0xcb8a):
> undefined reference to
> `arrow::DictionaryBuilder<arrow::FixedSizeBinaryType>::DictionaryBuilder(std::shared_ptr<arrow::DataType>
> const&, arrow::MemoryPool*)'
> CMakeFiles/arrow-array-test.dir/objects.a(array-dict-test.cc.obj):array-dict-test.cc:(.text+0xeef8):
> undefined reference to
> `arrow::DictionaryBuilder<arrow::FixedSizeBinaryType>::DictionaryBuilder(std::shared_ptr<arrow::DataType>
> const&, arrow::MemoryPool*)'
> CMakeFiles/arrow-array-test.dir/objects.a(array-dict-test.cc.obj):array-dict-test.cc:(.text+0x10240):
> undefined reference to
> `arrow::DictionaryBuilder<arrow::FixedSizeBinaryType>::DictionaryBuilder(std::shared_ptr<arrow::DataType>
> const&, arrow::MemoryPool*)'
> CMakeFiles/arrow-array-test.dir/objects.a(array-dict-test.cc.obj):array-dict-test.cc:(.text+0x104fc):
> undefined reference to
> `arrow::DictionaryBuilder<arrow::FixedSizeBinaryType>::AppendArray(arrow::Array
> const&)'
> CMakeFiles/arrow-array-test.dir/objects.a(array-dict-test.cc.obj):array-dict-test.cc:(.text+0x108ef):
> undefined reference to `arrow{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
