[
https://issues.apache.org/jira/browse/ARROW-4671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16783740#comment-16783740
]
Francois Saint-Jacques edited comment on ARROW-4671 at 3/4/19 8:08 PM:
-----------------------------------------------------------------------
The issue with Dictionary is that the DictionaryBuilder not only emits an
array, but also a modified type. This will break const-ness of MakeBuilder.
[~mrkn] what is your use case here
# do you want to the builder to use an existing dictionary type (this is
currently unsupported)?
# or are you only interested in providing the dictionary value type, e.g.
string in your case?
2. can be fixed quickly by adding a new `MakeDictionaryBuilder function, 1.
requires a refactor of the DictionaryBuilder class.
was (Author: fsaintjacques):
The issue with Dictionary is that the DictionaryBuilder not only emits an
array, but also a modified type. This will break const-ness of MakeBuilder.
[~mrkn] what is your use case here
# do you want to the builder to use an existing dictionary type (this is
currently unsupported)?
# or are you only interested in providing the dictionary value type, e.g.
string in your case6
2. can be fixed quickly by adding a new `MakeDictionaryBuilder function, 1.
requires a refactor of the DictionaryBuilder class.
> [C++] MakBuilder must care Type::DICTIONARY
> -------------------------------------------
>
> Key: ARROW-4671
> URL: https://issues.apache.org/jira/browse/ARROW-4671
> Project: Apache Arrow
> Issue Type: New Feature
> Components: C++
> Reporter: Kenta Murata
> Priority: Major
> Fix For: 0.13.0
>
>
> Now, we cannot create a builder for DictionaryArray by using MakeBuilder.
> When we pass DictionaryType to MakeBuilder, it says like below:
> {quote}MakeBuilder: cannot construct builder for type
> dictionary<values=string, indices=int8, ordered=1>
> {quote}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
