[
https://issues.apache.org/jira/browse/ARROW-4664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wes McKinney resolved ARROW-4664.
---------------------------------
Resolution: Fixed
Issue resolved by pull request 3854
[https://github.com/apache/arrow/pull/3854]
> [C++] DCHECK macro conditions are evaluated in release builds
> -------------------------------------------------------------
>
> Key: ARROW-4664
> URL: https://issues.apache.org/jira/browse/ARROW-4664
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++
> Reporter: Benjamin Kietzman
> Assignee: Wes McKinney
> Priority: Trivial
> Labels: pull-request-available
> Fix For: 0.13.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> {{DCHECK(potentially_expensive())}} will evaluate the argument even in
> release mode, and is used in several places with the assumption that it will
> do so (which means removing the guarantee of evaluation causes numerous
> failures). By contrast, most debug assertion macros elide their arguments
> entirely ({{<cassert>.assert}}, {{<glog/logging.h>}}) in release mode
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
