[ 
https://issues.apache.org/jira/browse/ARROW-4844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16790990#comment-16790990
 ] 

Jeroen edited comment on ARROW-4844 at 3/12/19 8:52 PM:
--------------------------------------------------------

Hmm I don't understand. How are bindings supposed to use `libarrow.a` if it 
depends on internal vendored libraries which are not shipped with the 
installation? There is no way to link to this?

It seems to me you either need to include the internal libdouble-conversion 
object files into `libarrow.a`, or alternatively ship libdouble-conversion.a 
along with libarrow.a in the installation (perhaps rename to 
libarrow_double-conversion.a) and update arrow.pc to link with "-larrow 
-ldouble-conversion"

Shared libs (dll files) are not permitted in R so we need a complete static 
build of libarrow.


was (Author: jeroenooms):
Hmm I don't understand. How are bindings supposed to use `libarrow.a` if it 
depends on internal vendored libraries which are not shipped with the 
installation? There is no way to link to this?

It seems to me you either need to include the internal libdouble-conversion 
object files into `libarrow.a`, or alternatively ship libdouble-conversion.a 
along with libarrow.a in the installation (perhaps rename to 
libarrow_double-conversion.a) and update arrow.pc to link with "-larrow 
-ldouble-conversion"

Shared libs (dll files) are not permitted in R so we need a static libarrow.

> Static libarrow is missing vendored libdouble-conversion
> --------------------------------------------------------
>
>                 Key: ARROW-4844
>                 URL: https://issues.apache.org/jira/browse/ARROW-4844
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: C++
>    Affects Versions: 0.12.1
>            Reporter: Jeroen
>            Priority: Major
>
> When trying to statically link the R bindings to libarrow.a, I get linking 
> errors which suggest that libdouble-conversion.a was not properly embedded in 
> libarrow.a. This problem happens on both MacOS and Windows.
> Here is the arrow build log: 
> https://ci.appveyor.com/project/jeroen/rtools-packages/builds/23015303/job/mtgl6rvfde502iu7
> {code}
> C:/rtools40/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/8.3.0/../../../../x86_64-w64-mingw32/bin/ld.exe:
>  
> C:/rtools40/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/8.3.0/../../../../lib/libarrow.a(cast.cc.obj):(.text+0x1c77c):
>  undefined reference to 
> `double_conversion::StringToDoubleConverter::StringToDouble(char const*, int, 
> int*) const'
> C:/rtools40/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/8.3.0/../../../../x86_64-w64-mingw32/bin/ld.exe:
>  
> C:/rtools40/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/8.3.0/../../../../lib/libarrow.a(converter.cc.obj):(.text+0x5fda):
>  undefined reference to 
> `double_conversion::StringToDoubleConverter::StringToDouble(char const*, int, 
> int*) const'
> C:/rtools40/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/8.3.0/../../../../x86_64-w64-mingw32/bin/ld.exe:
>  
> C:/rtools40/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/8.3.0/../../../../lib/libarrow.a(converter.cc.obj):(.text+0x6097):
>  undefined reference to 
> `double_conversion::StringToDoubleConverter::StringToDouble(char const*, int, 
> int*) const'
> C:/rtools40/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/8.3.0/../../../../x86_64-w64-mingw32/bin/ld.exe:
>  
> C:/rtools40/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/8.3.0/../../../../lib/libarrow.a(converter.cc.obj):(.text+0x6589):
>  undefined reference to 
> `double_conversion::StringToDoubleConverter::StringToFloat(char const*, int, 
> int*) const'
> C:/rtools40/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/8.3.0/../../../../x86_64-w64-mingw32/bin/ld.exe:
>  
> C:/rtools40/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/8.3.0/../../../../lib/libarrow.a(converter.cc.obj):(.text+0x6647):
>  undefined reference to 
> `double_conversion::StringToDoubleConverter::StringToFloat(char const*, int, 
> int*) const'
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to