[
https://issues.apache.org/jira/browse/ARROW-5311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16840410#comment-16840410
]
Joris Van den Bossche commented on ARROW-5311:
----------------------------------------------
With IndexError, we could match typical behaviour on the python side (out of
bound indices give IndexError in Python), but of course this is specific to
Python, so that should not necessarily drive a change on the C++ side.
> [C++] Return more specific invalid Status in Take kernel
> --------------------------------------------------------
>
> Key: ARROW-5311
> URL: https://issues.apache.org/jira/browse/ARROW-5311
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++
> Reporter: Joris Van den Bossche
> Assignee: Benjamin Kietzman
> Priority: Minor
> Labels: pull-request-available
> Fix For: 0.14.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently the {{Take}} kernel returns generic Invalid Status for certain
> cases, that could use more specific error:
> - indices of wrong type (eg floats) -> TypeError instead of Invalid?
> - out of bounds index -> new IndexError ?
> From review in https://github.com/apache/arrow/pull/4281
> cc [~bkietz]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
