Antoine Pitrou created ARROW-5403:
-------------------------------------
Summary: [C++] Test failures not propagated in Windows shared
builds
Key: ARROW-5403
URL: https://issues.apache.org/jira/browse/ARROW-5403
Project: Apache Arrow
Issue Type: Bug
Components: C++
Affects Versions: 0.13.0
Reporter: Antoine Pitrou
Fix For: 0.14.0
See https://github.com/google/googletest/issues/2261
Try e.g. this change:
{code}
diff --git a/cpp/src/arrow/buffer-test.cc b/cpp/src/arrow/buffer-test.cc
index 9b0530e5c..ce7628f55 100644
--- a/cpp/src/arrow/buffer-test.cc
+++ b/cpp/src/arrow/buffer-test.cc
@@ -35,6 +35,10 @@
namespace arrow {
TEST(TestAllocate, Bitmap) {
+ auto buf1 = Buffer::FromString("a");
+ auto buf2 = Buffer::FromString("b");
+ AssertBufferEqual(*buf1, *buf2);
+
std::shared_ptr<Buffer> new_buffer;
ARROW_EXPECT_OK(AllocateBitmap(default_memory_pool(), 100, &new_buffer));
EXPECT_GE(new_buffer->size(), 13);
{code}
On a Windows shared library build, it outputs this:
{code}
[==========] Running 31 tests from 11 test cases.
[----------] Global test environment set-up.
[----------] 2 tests from TestAllocate
[ RUN ] TestAllocate.Bitmap
..\src\arrow\testing\gtest_util.cc(120): error: Value of: buffer.Equals(expected
)
Actual: false
Expected: true
[ OK ] TestAllocate.Bitmap (0 ms)
[ RUN ] TestAllocate.EmptyBitmap
[ OK ] TestAllocate.EmptyBitmap (0 ms)
[----------] 2 tests from TestAllocate (0 ms total)
{code}
.... and the entire test file is marked passed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
