[ 
https://issues.apache.org/jira/browse/ARROW-5842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16878933#comment-16878933
 ] 

Liya Fan commented on ARROW-5842:
---------------------------------

[~jnadeau] Sounds reasonable. Thanks for your reminder.

Since the methods are declared public. This issue only revises the internal 
semantics, leaving the external semantics unchanged, only making the methods 
deprecated. 

Changing the external semantics will be a long process.

> [Java] Revise the semantic of lastSet in ListVector
> ---------------------------------------------------
>
>                 Key: ARROW-5842
>                 URL: https://issues.apache.org/jira/browse/ARROW-5842
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: Java
>            Reporter: Liya Fan
>            Assignee: Liya Fan
>            Priority: Trivial
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The {{lastSet}} member in ListVector seems misleading. According to the name, 
> it should refers to the last index that is actually set. However, from the 
> context of the code, it actually means the next index that will be set.
> We fix this problem, and make it consistent with the {{lastSet}} in 
> {{BaseVariableWidthVector}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to