[ 
https://issues.apache.org/jira/browse/ARROW-6151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16901434#comment-16901434
 ] 

Neal Richardson commented on ARROW-6151:
----------------------------------------

Me too. This was discussed here: 
[https://github.com/apache/arrow/pull/4908#discussion_r306586276]

I first proposed a shim NOTICE file in the R package that contained a link to 
the official NOTICE. That would keep a single source of truth for the NOTICE 
and still satisfy the CRAN request. When you requested the full NOTICE be 
included, I copied it there, and then added to the {{r/Makefile}} 
[https://github.com/apache/arrow/blob/master/r/Makefile#L33], which copies the 
NOTICE file every time {{make build}} is run, which happens when checking 
locally. Given the constraints, this seemed like the best option that would 
ensure that the full NOTICE file is included in the R package without requiring 
on human discipline to manually copy it in every time, while also providing a 
mechanism by which it gets synced with the official version. 

> [R] See if possible to generate r/inst/NOTICE.txt rather than duplicate 
> information
> -----------------------------------------------------------------------------------
>
>                 Key: ARROW-6151
>                 URL: https://issues.apache.org/jira/browse/ARROW-6151
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: R
>            Reporter: Wes McKinney
>            Priority: Major
>
> I noticed this file -- I am concerned about its maintainability. 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to