[ 
https://issues.apache.org/jira/browse/ARROW-6183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16903540#comment-16903540
 ] 

James Lamb commented on ARROW-6183:
-----------------------------------

I'm also not trying to take sides or force anyone to take sides. In my opinion 
saying "pass a vector of column names" would be preferable to the current state 
which is "pass this object from *tidyselect* package but also a vector of 
column names will work".

And then outside of *feather::read_feather()*, I'm unsure why *arrow* needs to 
re-export all of these functions 
([https://github.com/apache/arrow/blob/master/r/R/reexports-tidyselect.R]) or 
have *tidyselect* as an "Imports" dependency.

> [R] factor out tidyselect?
> --------------------------
>
>                 Key: ARROW-6183
>                 URL: https://issues.apache.org/jira/browse/ARROW-6183
>             Project: Apache Arrow
>          Issue Type: Wish
>          Components: R
>            Reporter: James Lamb
>            Priority: Minor
>
> I noticed tonight that several functions from the *tidyselect* package are 
> re-exported by *arrow*. Why is this necessary? In my opinion, the *arrow* R 
> package should strive to have as few dependencies as possible and should have 
> no opinion about which parts of the R ecosystem ("tidy" or otherwise) are 
> used with it.
> I think it would be valuable to cut the *tidyselect* re-exports, and to make 
> *feather::read_feather()*'s argument *col_select* take a character vector of 
> column names instead of a "*tidyselect::vars_select()"* object. I think that 
> would be more natural and would be intuitive for a broader group of R users.
> Would you be open to removing *tidyselect* and changing 
> *feather::read_feather()* this way?



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to