[ 
https://issues.apache.org/jira/browse/ARROW-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated ARROW-6232:
----------------------------------
    Labels: pull-request-available  (was: )

> [C++] Rename Argsort kernel to SortIndices
> ------------------------------------------
>
>                 Key: ARROW-6232
>                 URL: https://issues.apache.org/jira/browse/ARROW-6232
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++
>            Reporter: Sutou Kouhei
>            Assignee: Sutou Kouhei
>            Priority: Major
>              Labels: pull-request-available
>
> "Argsort" is NumPy specific name. Other languages/libraries use
> different name:
>   * R: order
>     * 
> https://cran.r-project.org/doc/manuals/r-release/fullrefman.pdf#Rfn.order
>   * MATLAB: sort
>     * https://mathworks.com/help/matlab/ref/sort.html
>     * "sort" returns sorted array and indices to sort array
>   * Julia: sortperm
>     * 
> https://pkg.julialang.org/docs/julia/THl1k/1.1.1/base/sort.html#Base.sortperm
> It's better that we use general name because Arrow C++ isn't a NumPy
> compatible library.
> "SortIndices" means "sort that returns indices array". We can add
> "SortValues" or something for sort kernel that returns values array.
> "SortIndices" may be easily mistaken for "sort by indices".



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to